NPM_CONFIG environment variable can technically have a hyphen

node-gradle · Dec 14, 2021 · 9418c44 · 9418c44
1 parent 90b574a
commit 9418c44
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/main/kotlin/com/github/gradle/node/npm/proxy/NpmProxy.kt b/src/main/kotlin/com/github/gradle/node/npm/proxy/NpmProxy.kt
@@ -16,8 +16,10 @@ class NpmProxy {
 
         // And since npm also takes settings in the form of environment variables with the
         // NPM_CONFIG_<setting> format, we should check those. Hopefully nobody does this.
+        // Windows will let you set environment variables with hyphens in them, but shells
+        // on Linux will fight you so you'll have to be sneaky, adding both here "just in case".
         private val npmProxyVariables = listOf(
-                "NPM_CONFIG_PROXY", "NPM_CONFIG_HTTPS-PROXY", "NPM_CONFIG_NOPROXY"
+                "NPM_CONFIG_PROXY", "NPM_CONFIG_HTTPS-PROXY", "NPM_CONFIG_HTTPS_PROXY", "NPM_CONFIG_NOPROXY"
         )
 
         fun computeNpmProxyEnvironmentVariables(): Map<String, String> {