Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1033 I have not been able to compile all the way to xclbin, because the value of options.emitCtrlPkt over here in the code when I print it is 17, even though the default value is false (0).
I don't know where the bug is, iree-amd-aie, iree, or the clang C++ compiler I'm using. I've spent some time trying to find some invalid code, but without any success. The change in this PR fixes my problem, although it's definitely just a workaround for another deeper issue (initializing with {false} instead of = false should be valid afaik).
The only nice thing about this PR is that IREE initializes options with
= false
instead of{false}
, so at least we're aligning with IREE.