Merge abandonware changes #457
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I20bb0967fee6eca1acb9ef7998cf68260a87346b Origin: noble#436
node-10 support to come later Forwarded: noble#422 Origin: CrossStream@6e0d5d6 Change-Id: Ie8c3b328fd8736a80a3b91fb23702cc4152943b4 Signed-off-by: Philippe Coval <[email protected]>
Check the error code instead of the error message as the message is not guaranteed to be stable.
|
review welcome |
|
Hi and hacky new year ! Is anyone still alive here ? :) Relate-to: abandonware/abandonware.github.io#8 |
|
I tried to reach @sandeepmistry once but no feedback since ... help welcome |
|
Becauee of the fact that bleno now not actively maintained since 5 years we now neeed to break the idea to just release patch releases. Bleno was coverted to ES6 classes and also dependencies requires breaking changes, so we will soon release 0.6.0 of the abandonware package (abandonware#42) ... It would be great to get in the end all aandonware changes in here and pot reactivate te noble orga |
|
Feedback welcome on our latest release: https://www.npmjs.com/package/@abandonware/bleno/v/0.6.1 Relate-to: abandonware#17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is the first serie of patches, once merged I will rebase @abandonware on it and forward a new set.