test: E2E test showing client2 authentication fails#2
Closed
Conversation
This test would fail with the current implementation because client2 is dropped from the cache (only client1, the first alphabetically, is preserved). The existing E2E tests only tested client1, which is why the bug went undetected. This test demonstrates that authentication with client2 fails due to the filtering bug. Signed-off-by: Alexej Disterhoft <alexej@disterhoft.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E2E Test Only - Demonstrates Bug
This PR contains only the E2E test addition (no unit test changes) to demonstrate that API key authentication fails for client2.
What this shows:
key2(client2)client1is preserved in cacheWhy it fails:
The secret filtering bug drops all client IDs except the first one alphabetically. The existing E2E tests only used
client1, so the bug went undetected.Related:
fix/api-key-filtering