-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added vegtype dependent FRP to FlameH calculations. #88
Conversation
I convert this to a draft, as when reading Alexander and Cruz, it may be more appropriate to use a vegtype dependent calculations of crown scorch height (hs), which can be related directly to flame height (hf) (see Table 2 and equation 14 in their paper). I will add this option as well. |
@angehung5 What do you think about this PR, will you give it a review? Not sure it will have enough impact yet to warrant changing your paper results for midflame wind and WAF. However, you mentioned you had comments on the new NL variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I haven't get a chance to test it, but I changed flameh_frp to flameh_cal (option for flameh calculation). Hope it is more clear.
You can go ahead and merge it to develop. I will find time to run some tests later.
This PR address Closes #86 , which stems from Wei-Ting's canopy-wind/WAF paper, and the work of Alexander and Cruz (2012) (Table 1 and S1) that shows different vegetation type dependent relationships for deriving flame height based on fire intensity.
Previously we had used the single relationship based on Byram (1959) (also included in Table 1 of Alexander and Cruz (2012)) to derive flame height from FRP, and here we extend it to a methodology that is approximately related to model input vegetation type (currently supporting MODIS/VIIRS).
For the limited SE example using the FRP to flame height only option in canopy-app:
Byram (1959) Flame Heights
Alexander and Cruz (2012) - Byram (1959) Flame Heights
@angehung5 When you return from leave, can you more robustly help test this new feature?