-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tleaf ppfd #80
Tleaf ppfd #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With results staying same as you say, I think this is fine.
I think the rad and ppfd mods could be combined into one (probably rad) though.
Co-authored-by: Zachary Moon <[email protected]>
Co-authored-by: Zachary Moon <[email protected]>
@zmoon Good suggestion. I have now combined the ppfd mod into rad. Let me know if good to go. |
@drnimbusrain Guess can use the latest develop branch now to build upon right? |
Hi Quazi, Yes, go on ahead!!
…On Fri, Jul 28, 2023, 2:47 PM Quazi Ziaur Rasool ***@***.***> wrote:
@drnimbusrain <https://github.com/drnimbusrain> Guess can use the latest
develop branch now to build upon right?
—
Reply to this email directly, view it on GitHub
<#80 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGLFYNUSENZISUPR7GFNWY3XSQCLFANCNFSM6AAAAAA2TI5FFU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This PR contains commits to restructure the biogenics and removes the parameterization calculations of FSUN, Tleaf, and PPFD. These are now separate modules/subroutines (i.e., canopy_rad_mod.F90, canopy_tleaf_mod.F90, and canopy_ppfd_mod.F90) and calculate necessary variables as inputs to the biogenic module. This facilitates use of these canopy physical profile variables for other canopy-app processes upcoming (e.g., dry deposition), and for including future options for more robust ways in their calculations.
I have checked that these changes do not alter the biogenic emissions calculations:
Previous:
New: