Add ozone W126

[angehung5]

#124
SE example files updated. README is also updated by adding a brief description of w126. Please check if that is correct.

[drnimbusrain]

@angehung5 do you think it's ok to leave values over ocean as zeros? Or should I replace with nans? How does the other canopy variable treat this? This is a question from @MaggieMarvin

[drnimbusrain]

@angehung5 Also, even though I haven't added the canopy-app code changes to read in W126, does your changes here work ok in testing both default NC and TXT examples with the new data there?

[drnimbusrain]

@MaggieMarvin I think you should also review these changes quickly.

[angehung5]

@MaggieMarvin It should be ok to leave oceans as zeros. I will change them to zeros anyway since nans may break the code, unless you want to put other values (e.g. -999).

@drnimbusrain Yes, it should work. I just add a new variable to the files, nothing else changes.

[zmoon]

Is it always rounded to the closest integer?

[drnimbusrain]

Good point Zach, can you check Maggie and Wei-Ting

…

On Mon, Jul 8, 2024, 2:10 PM Zachary Moon ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In input/point_file_20220630.sfcf023.txt <#137 (comment)> : > @@ -1,2 +1,2 @@ -lat,lon,ch,ugrd10m,vgrd10m,clu,lai,vtype,canfrac,fricv,csz,sfcr,mol,frp,href,sotyp,pressfc,dswrf,shtfl,tmpsfc,tmp2m,spfh2m,hpbl,prate_ave,soilw1,soilw2,soilw3,soilw4,wilt -34.03,272.11,20.8692,-0.7485,0.3286,0.5214,3.7059,4,0.2966,0.1107,0.0416,0.8260,12.2366,0.0000,10.00,3,99731.6094,10.1607,-9.8159,292.9766,293.2202,0.0146,14.0288,0.0001,0.2591,0.2053,0.2134,0.2132,0.0470 +lat,lon,ch,ugrd10m,vgrd10m,clu,lai,vtype,canfrac,fricv,csz,sfcr,mol,frp,href,sotyp,pressfc,dswrf,shtfl,tmpsfc,tmp2m,spfh2m,hpbl,prate_ave,soilw1,soilw2,soilw3,soilw4,wilt,ozone_w126 +34.03,272.11,20.8692,-0.7485,0.3286,0.5214,3.7059,4,0.2966,0.1107,0.0416,0.8260,12.2366,0.0000,10.00,3,99731.6094,10.1607,-9.8159,292.9766,293.2202,0.0146,14.0288,0.0001,0.2591,0.2053,0.2134,0.2132,0.0470,85 Is it always rounded to the closest integer? — Reply to this email directly, view it on GitHub <#137 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGLFYNUWL5J3ETCSJQQIJ23ZLLIZVAVCNFSM6AAAAABKRFKQQ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNRUGAZTENJXGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[angehung5]

According to EPA's definition (https://www.epa.gov/sites/default/files/2015-09/documents/w126_steps_to_calculate_revised_feb19.pdf), W126 could be floating numbers but they all integers in the file /groups/NA22OAR/pcampbe8/gfsv16_ozone_w126/gfsv16_ozone_w126_042021-042024.nc.
@MaggieMarvin Could you double check? Thanks!

[MaggieMarvin]

Looks great to me! The input NC files have correct values and the test case runs just fine - just needs typo fix "later" to layer in README (line 173)

[MaggieMarvin]

Thanks Wei-Ting! In the very last step the guidance is to round to the nearest whole number so that's what I've done here

[drnimbusrain]

Great Maggie! Does TXT test case also still work fine?

…

On Mon, Jul 8, 2024, 2:37 PM Maggie Marvin ***@***.***> wrote: Thanks Wei-Ting! In the very last step the guidance is to round to the nearest whole number so that's what I've done here — Reply to this email directly, view it on GitHub <#137 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGLFYNUPB5IXLAKW5SFTAWLZLLL7XAVCNFSM6AAAAABKRFKQQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJUHEYTEMBXGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[MaggieMarvin]

Yes! For both gridded and point test cases

[drnimbusrain]

just small typo correction. approved.

[drnimbusrain]

@angehung5 @MaggieMarvin I merged, but seeing some strange values in the SE example files: