Update global data process #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drnimbusrain
requested changes
Apr 3, 2024
There was a problem hiding this comment.
@angehung5 Thank you for modifying and brining this back! I have some comments and changes.
Co-authored-by: Patrick Campbell <[email protected]>
Co-authored-by: Patrick Campbell <[email protected]>
Co-authored-by: Patrick Campbell <[email protected]>
drnimbusrain
requested changes
Apr 3, 2024
There was a problem hiding this comment.
@angehung5 Thank you for the changes. Just one more small change.
Co-authored-by: Patrick Campbell <[email protected]>
drnimbusrain
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for global_data_process.py:
Put the global data process components back in python README and slurm script.