chore(deps): bump actions/setup-dotnet from 5.2.0 to 5.3.0 in the github-actions group#24
Merged
github-actions[bot] merged 1 commit intoJun 1, 2026
Conversation
Bumps the github-actions group with 1 update: [actions/setup-dotnet](https://github.com/actions/setup-dotnet). Updates `actions/setup-dotnet` from 5.2.0 to 5.3.0 - [Release notes](https://github.com/actions/setup-dotnet/releases) - [Commits](actions/setup-dotnet@c2fa09f...9a946fd) --- updated-dependencies: - dependency-name: actions/setup-dotnet dependency-version: 5.3.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
deleted the
dependabot/github_actions/github-actions-48e1889820
branch
June 1, 2026 23:54
FarmLox
added a commit
that referenced
this pull request
Jul 19, 2026
Six items the user explicitly told me to stop dismissing. (1) ISettingsService.Save was a void wrapper around TrySave that discarded the bool. Three call sites used it. Removed Save from the interface; call sites now use `_ = TrySave(...)` so the discard is explicit. Tests updated. (review #21) (2) MainWindow's title-bar Maximize/Restore glyphs used literal Unicode characters. Switched to \u escape form so source-file encoding isn't load-bearing. (review #25) (3) IsExternallyBlocked was a settable observable on ScanViewModel that MainViewModel wrote from outside. Refactored: ScanViewModel takes a Func<bool> isExternallyBlocked at construction and exposes NotifyExternallyBlockedChanged() for the parent to call. The "this field is meant to only be set by MainViewModel" footgun is gone. (review #34) (4) WindowChromeExtensions.EnableAltSpaceSystemMenu registered a PreviewKeyDown handler that was never unhooked. No leak today (the window was the GC root) but inconsistent with how every other window unhooks its handlers in OnClosed. Tightened to match. (review #24) (5) Indeterminate-progress 9-line comment collapsed to four lines naming the constraint. The hardcoded 320 max-travel constant stays because DoubleAnimation can't template-bind ActualWidth. (review #27) (6) Stale 2026-04-23 reminder removed from MEMORY.md (user has already submitted to AlternativeTo and InstallerClean already appears as a PatchCleaner alternative).
FarmLox
added a commit
that referenced
this pull request
Jul 19, 2026
The audit (v1.8.2 round 1, finding #24) flagged that WPF's UIA bridge has historically not re-fired LiveRegionChanged for a Visibility= Collapsed→Visible transition; the announcement only fires when an existing-in-tree element's text changes. The pending-reboot and missing-from-disk banners both reveal that way, so a screen-reader user could see Move and Delete disabled with no announcement of why. Both fix paths have real cost: an Opacity-based always-in-tree hide imposes a permanent ~24px gap on every main-window load, and a code-behind RaiseAutomationEvent path needs Dispatcher.BeginInvoke plumbing so the text binding settles before the event fires. The actual .NET 10 WPF behaviour against this transition is unconfirmed by a live NVDA / Narrator pass; deferring an unverified fix that costs layout or code-behind complexity is honest. Note added at the pending-reboot banner explaining the choice and the two paths so a future contributor revisiting this on a screen-reader complaint has the receipts. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
FarmLox
added a commit
that referenced
this pull request
Jul 19, 2026
WPF's UIA bridge has historically not re-fired LiveRegionChanged for a Visibility=Collapsed→Visible transition; the bridge announces text changes inside an already-rendered subtree but not the subtree itself entering the tree. The pending-reboot and missing-from-disk banners both reveal that way, so a screen-reader user could see Move and Delete disabled with no announcement of why. OnScanPropertyChanged in MainWindow code-behind now watches the HasPendingReboot and HasMissingFromDisk transitions to true and raises LiveRegionChanged on the corresponding TextBlock's AutomationPeer. Dispatcher.BeginInvoke with Loaded priority defers past the text-binding update so the peer's text is current when the announcement fires. Audit synthesis #24 was deferred at the time with a long XAML comment documenting the two fix paths and their costs. The actual .NET 10 WPF behaviour against this transition is unconfirmed by a live NVDA / Narrator pass, but the code-behind raise is defensive: if WPF actually fires the event on its own, the explicit raise coalesces in the screen reader (Narrator and NVDA deduplicate LiveRegionChanged events within a window); if it doesn't, the explicit raise fixes the silence. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
FarmLox
pushed a commit
that referenced
this pull request
Jul 19, 2026
Bumps the github-actions group with 1 update: [actions/setup-dotnet](https://github.com/actions/setup-dotnet). Updates `actions/setup-dotnet` from 5.2.0 to 5.3.0 - [Release notes](https://github.com/actions/setup-dotnet/releases) - [Commits](actions/setup-dotnet@c2fa09f...9a946fd) --- updated-dependencies: - dependency-name: actions/setup-dotnet dependency-version: 5.3.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the github-actions group with 1 update: actions/setup-dotnet.
Updates
actions/setup-dotnetfrom 5.2.0 to 5.3.0Release notes
Sourced from actions/setup-dotnet's releases.
Commits
9a946fdAdd rollForward note in README, improve proxy health check in e2e tests and b...98af08bSupport global.json's rollForward latest* variants (#538)8404272Update install scripts to v2026.05.19 (#736)f1970f5Don't download releases-index.json to resolve major version (#560)af9211bAdd dotnet-version: latest support with dotnet-channel input (#730)df991aechore: bump @actions/* and fast-xml-parser dependencies (#728)a66eefaCI: remove manual PowerShell install from test-proxy job (e2e-tests.yml) (#703)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions