Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognise key declarations to automatically set accidentals #600

Merged
merged 21 commits into from
Jan 26, 2023
Merged

Recognise key declarations to automatically set accidentals #600

merged 21 commits into from
Jan 26, 2023

Conversation

no-chris
Copy link
Owner

@no-chris no-chris commented Jan 25, 2023 •
edited
Loading

https://chordmark.netlify.app/docs/reference/keys

breaking: removed harmonizeAccidentals flag

#v
key C#m
C#m7 G#7
_ What will you do when you get _lonely?
C#m7.. C. D. E.. E7..
_No one _waiting _by your _side _
F#m.. B.. E.. A..
_You've been _runnin' and _hiding much too _long
%
_You know it's _just your foolish _pride

#c
key Dm
Dm.. Bb..
Layla_
C.. Dm.. Dm.. Bb..
_Got me on my _knees, Layla
%
I'm _beggin' darling _please, Layla
C.. Dm.. Dm.. Bb.. C.. A. C.
_Darling won't you _ease my worried m_ind?

no-chris added 16 commits January 20, 2023 23:57
@no-chris
relax section label parsing rules by allowing multiple spaces between…
34f2385 
… the label and the multiplier
@no-chris
add isKeyDeclaration matcher
f848203
@no-chris
add parseKeyDeclaration
8f945c5
@no-chris
add key declaration parsing in the main song parsing function
b55b791
@no-chris
add key declaration template
0f198d5
@no-chris
add key declaration styles
f7fdee3
@no-chris
add per chord duration, isFirst and isLast to the song's chord index
1d8d71d
@no-chris
add key helpers to automatically detect the key of a song
27877e6
@no-chris
update SongChord's jsdoc with duration property
ed9dcc0
@no-chris
Add transposeKey() and improve other key helpers
bd8ff96
@no-chris
Skip NC symbol in getAllChordsInSong
e85996f
@no-chris
return chord model in key declaration
e45ae06
@no-chris
update chord symbol to 4.0.0-beta.0
20debbc
@no-chris
Fix accidentals in key helpers
902ceed
@no-chris
Update key declaration renderer to use rendered symbol
c638399
@no-chris
Adapt main rendering function, update unit tests
fa2ab3f
@no-chris no-chris added enhancement New feature or request breaking Breaking changes labels Jan 25, 2023
@no-chris no-chris self-assigned this Jan 25, 2023
@coveralls
Copy link

coveralls commented Jan 25, 2023 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 96ee9d4 on handle-keys
into a4e1f8d on master.

no-chris
no-chris commented Jan 25, 2023
View reviewed changes
Copy link
Owner Author

@no-chris no-chris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check bug (?) in repeated section when the key declaration is in the section (ex: layla)

@no-chris
apply misc improvements
58aa778
@no-chris
move key detection to parser
1afa056 
add AllKeys property to the parsed object
add accidental property to the KeyDeclaration object
@no-chris no-chris changed the title Handle keys Recognise key declarations to automatically set accidentals Jan 26, 2023
@no-chris no-chris merged commit aa1ecd7 into master Jan 26, 2023
@no-chris no-chris deleted the handle-keys branch January 26, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@no-chris no-chris

Labels
breaking Breaking changes enhancement New feature or request
Projects
The ChordMark Project
Status: Archive
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@no-chris @coveralls