Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/api change #31

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Refactor/api change #31

merged 5 commits into from
Oct 14, 2024

Conversation

mark-beck
Copy link
Contributor

Added flutter plugin and flutter example app.

WyvernIXTL
WyvernIXTL approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@WyvernIXTL WyvernIXTL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really say much regarding the flutter app. Maybe it should be named flutter_example_app?

The rest is good. Though we should soon standardize, what padding scheme are to be used and where the HMAC comes into play when symmetrically encrypting.

@mark-beck mark-beck merged commit bb05063 into nmshd:refactor/api-change Oct 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyvernIXTL WyvernIXTL WyvernIXTL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mark-beck @WyvernIXTL