Fixed local ip lookup on macOS GitHub instances. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmoinvaz
force-pushed
the
nathan/dev/macos-myip
branch
from
19d8f2b
to
c55fe58
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 57.18% 57.21% +0.03%
==========================================
Files 53 53
Lines 4639 4668 +29
Branches 1071 1076 +5
==========================================
+ Hits 2653 2671 +18
- Misses 1299 1306 +7
- Partials 687 691 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nmoinvaz
force-pushed
the
nathan/dev/macos-myip
branch
6 times, most recently
from
f625b46
to
29cc7f0
Compare
myIpAddress() and myIpAddressEx() should be enumerating the network interfaces and returning the local addresses with getifaddrs/GetAdapterAddresses. Where as, dnsResolve() and dnsResolveEx() enumerates resolved host names using getaddrinfo.
nmoinvaz
force-pushed
the
nathan/dev/macos-myip
branch
from
29cc7f0
to
6cf4e27
Compare
sergio-nsk
reviewed
Dec 12, 2023
sergio-nsk
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
myIpAddress()andmyIpAddressExshould be enumerating the network interfaces and returning the local addresses withgetifaddrs/GetAdapterAddresses.Where as,
dnsResolve()anddnsResolveEx()enumerates resolved host names usinggetaddrinfo.