Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #154 #156

Merged
merged 1 commit into from
May 14, 2021
Merged

Fix for issue #154 #156

merged 1 commit into from
May 14, 2021

Conversation

TomBailey167
Copy link
Contributor

@TomBailey167 TomBailey167 commented Apr 30, 2021

Fix for issue #154. useEffect dependencies updated to include [date]. This prevents an issue where my nested component doesn't update on its own.

Thank you to Brennan for the solution (#154 (comment)).

Fix for issue nmn#154. useEffect dependencies updated to include [date]. This prevents an issue where my nested <TimeAgo /> component doesn't update on its own.
@nmn nmn merged commit 26f096e into nmn:master May 14, 2021
@nmn
Copy link
Owner

nmn commented May 14, 2021

Technically there are even more missing dependencies, but I'll fix them on my end.

Thanks for the contribution.

@TomBailey167
Copy link
Contributor Author

Yes I did spot them but I'd already submitted the pull request so just left them.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants