Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installation of dependencies in doc-and-style causing problems? #69

Closed
iantaylor-NOAA opened this issue Jun 1, 2023 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@iantaylor-NOAA
Copy link
Collaborator

Hi @k-doering-NOAA,
Thanks for the continued usefulness of {ghactions4r} and sorry to bug you with a problem.

A recent change in r4ss to use importFrom of specific functions within {kableExtra} rather than the whole package (which caused a conflict with dplyr, see r4ss/r4ss#819).

Now, the call-doc-and-style workflow is failing with the error Error: Error in load_imports(path) : The package "kableExtra" is required. Looking back through the action messages, I see (at this point):

ERROR: dependency ‘rvest’ is not available for package ‘kableExtra’
* removing ‘/home/runner/work/_temp/Library/kableExtra’

This is not an error in other packages or locally on my machine.
@kellijohnson-NOAA wisely pointed out that the dependency installation might be different in doc-and-style than in other actions, and indeed, I see the use of remotes::install_deps(dependencies = TRUE) at

remotes::install_deps(dependencies = TRUE)

as opposed to the r-lib/actions/setup-r-dependencies used in doc-and-style prior to eb8b6fb as well as in other yml files. I don't know the history that prompted the change, but before that commit, doc-and-style was using setup-r-dependencies@v1 whereas others are using v2 (e.g. r-cmd-check). Would it be worth trying ``setup-r-dependencies@v2` to see if that works for whatever cases necessitated the change as well as fixing the r4ss action?

@k-doering-NOAA k-doering-NOAA self-assigned this Jun 2, 2023
@k-doering-NOAA k-doering-NOAA added the bug Something isn't working label Jun 2, 2023
k-doering-NOAA added a commit that referenced this issue Jun 2, 2023
Issue #69: use v2 of setup r dependencies
@k-doering-NOAA
Copy link
Collaborator

@iantaylor-NOAA thanks so much! I think I missed this one when I updated all the other workflows to use setup-r-dependencies@v2 and replacing it (already merged in) seems to work- I just ran doc and style on the r4ss main branch manually and it worked fine, generating r4ss/r4ss#821

Feel free to reopen if problems pop up.

@iantaylor-NOAA
Copy link
Collaborator Author

Looks good. Thank you for dealing with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants