Stop using ref in builtins.fetchGit fetcher#268
Merged
Conversation
Instead, sources now record either `branch` or `tag`. The fetcher specifies the correct ref (`/refs/heads/...` or `/refs/tags/...`) which works in the newest version of Nix. The `ref` attribute can still be set to override the logic.
This adds some warnings when users with existing `ref`-laden sources try to `niv update`.
This was referenced Aug 21, 2020
knl
pushed a commit
to knl/niv-updater-action
that referenced
this pull request
Aug 28, 2020
Recent [changes in niv](nmattia/niv#268) dropped the usage of `ref` as a branch in git sources. The new attribute name is `branch`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, sources now record either
branchortag. The fetcherspecifies the correct ref (
/refs/heads/...or/refs/tags/...) whichworks in the newest version of Nix. The
refattribute can still be setto override the logic.
Fixes #266