Conversation
kylebarron
reviewed
Oct 8, 2024
|
|
||
| let localij_arrays = LocalIJArrays::try_new(anchorarray, i_array, j_array).into_pyresult()?; | ||
|
|
||
| let cellarray = if set_failing_to_invalid { |
Contributor
There was a problem hiding this comment.
FYI not holding the py: Python token does not mean that it will automatically release the GIL. You always need to manually release the GIL with py.allow_threads
Owner
Author
There was a problem hiding this comment.
Yes. I misunderstood that and already used allow_threads in many places.
Contributor
There was a problem hiding this comment.
FWIW I also misunderstood that at first and assumed that not holding py meant you automatically would release the GIL. It would be really cool if it did work that way!
Owner
Author
|
Closing in favor of #64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55