-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
MSVC: make #4526 pass (use #if for optional) - fixes #3859; re-amalgamate #4970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Niels Lohmann <[email protected]>
|
I don't understand what's happening with this PR. It is not showing the change in the original file, but it is showing it in the amalgamated file, and there's no complaint about that from the checks. Also strange, there are only 5 checks. |
|
@gregmarr i think most workflows are awaiting approval because it is my first contribution, and the changes in the source files has been made in previous commits, the latest commits just amalgamated the headers, that's why at first it may look like only the amalgamated files are modified |
🔴 Amalgamation check failed! 🔴The source code has not been amalgamated. @chelseadzdr |
|
This pull request has been marked as stale because it has had no activity for 30 days. While we won’t close it automatically, we encourage you to update or comment if it is still relevant. Keeping pull requests active and up-to-date helps us review and merge changes more efficiently. Thank you for your contributions! |
Changes made
Existing issue is referenced:
How I tested
Amalgamation
py -3 tools\amalgamate\amalgamate.py.