Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set parents after insert call #4537

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Set parents after insert call #4537

merged 2 commits into from
Dec 18, 2024

Conversation

nlohmann
Copy link
Owner

Closes #3915

@nlohmann nlohmann self-assigned this Dec 12, 2024
@nlohmann nlohmann mentioned this pull request Dec 12, 2024
Closed
2 tasks
@coveralls
Copy link

Coverage Status

coverage: 99.65%. remained the same
when pulling cb41608 on issue3915
into e6cafa5 on develop.

@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Dec 16, 2024
@nlohmann nlohmann added this to the Release 3.11.4 milestone Dec 18, 2024
@nlohmann nlohmann merged commit 094bd26 into develop Dec 18, 2024
122 checks passed
@nlohmann nlohmann deleted the issue3915 branch December 18, 2024 08:44
nlohmann added a commit that referenced this pull request Dec 18, 2024
@nlohmann
Set parents after insert call (#4537)
851584e 
* 🐛 set parents after insert call

* 🚨 fix warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlohmann nlohmann

Labels
M review needed It would be great if someone could review the proposed changes. tests
Projects
None yet
Milestone
Release 3.11.4
Development

Successfully merging this pull request may close these issues.

JSON_DIAGNOSTICS trigger assertion
2 participants
@nlohmann @coveralls