Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed an error in the Custom data source example. #4335

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Fixed an error in the Custom data source example. #4335

merged 1 commit into from
Apr 8, 2024

Conversation

philip-paul-mueller
Copy link
Contributor

The target member of the MyIterator class was used as if it was a reference, but it is a pointer.
Furthermore, the increment operator used advance() as a static function, which it is not.

nlohmann
nlohmann approved these changes Apr 8, 2024
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.4 milestone Apr 8, 2024
@nlohmann nlohmann merged commit 16b3d84 into nlohmann:develop Apr 8, 2024
3 checks passed
@nlohmann
Copy link
Owner

nlohmann commented Apr 8, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees
No one assigned
Labels
documentation S
Projects
None yet
Milestone
Release 3.11.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philip-paul-mueller @nlohmann