Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix patch::add creating nonexistent parents #3628

Merged
merged 2 commits into from
Jul 30, 2022
Merged

Fix patch::add creating nonexistent parents #3628

merged 2 commits into from
Jul 30, 2022

Conversation

falbrechtskirchinger
Copy link
Contributor

Replacement for #3199. (Original author MIA.)

Fixes #3134.
Closes #3199.

@coveralls
Copy link

coveralls commented Jul 29, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 4f8f310 on falbrechtskirchinger:fix-patch-add into d1d79b9 on nlohmann:develop.

Hudson00 and others added 2 commits July 29, 2022 18:33
@Hudson00 @falbrechtskirchinger
Fix patch::add creating nonexistent parents
6eb5329 
The previous behavior was not in accordance with RFC6902.
Add unit test.

Fixes nlohmann#3134.
@falbrechtskirchinger
Fix incorrect JSON patch unit test
4f8f310
nlohmann
nlohmann approved these changes Jul 30, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Jul 30, 2022
@nlohmann nlohmann added this to the Release 3.11.0 milestone Jul 30, 2022
@nlohmann nlohmann merged commit fca1ddd into nlohmann:develop Jul 30, 2022
@falbrechtskirchinger falbrechtskirchinger deleted the fix-patch-add branch July 30, 2022 19:25
@gregmarr gregmarr mentioned this pull request Feb 14, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

@gregmarr gregmarr gregmarr approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🐛 bug fix
Projects
None yet
Milestone
Release 3.11.0
Development

Successfully merging this pull request may close these issues.

Applying JSON patch creates parent object
5 participants
@falbrechtskirchinger @coveralls @nlohmann @gregmarr @Hudson00