Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unicode test timeout (for real this time!) #3614

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

falbrechtskirchinger
Copy link
Contributor

The previous attempt didn't quite do the job because TIMEOUT_AFTER_MATCH doesn't work as expected. This sets the timeout of test-unicode4 to twice the default (i.e., 3000s).

Fixes #3579.

@coveralls
Copy link

coveralls commented Jul 27, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling cfcee93 on falbrechtskirchinger:fix-timeout into 2d48a4d on nlohmann:develop.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Jul 28, 2022
@nlohmann nlohmann added this to the Release 3.11.0 milestone Jul 28, 2022
@nlohmann nlohmann merged commit 5520761 into nlohmann:develop Jul 28, 2022
@falbrechtskirchinger falbrechtskirchinger deleted the fix-timeout branch July 28, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unicode4 test consistently fails on RISC-V hardware
3 participants