Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add header to use value_t #2948

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Add header to use value_t #2948

merged 1 commit into from
Aug 18, 2021

Conversation

nlohmann
Copy link
Owner

This PR adds a missing include to use value_t inside hash.hpp. It was not detected by the CI, because the function using value_t is templated, but never instantiated.

Replaces #2873

@nlohmann nlohmann added this to the Release 3.10.1 milestone Aug 18, 2021
@nlohmann nlohmann self-assigned this Aug 18, 2021
@nlohmann nlohmann mentioned this pull request Aug 18, 2021
Closed
4 tasks
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cfb71ad on missing_header into f42a74b on develop.

@nlohmann nlohmann merged commit 5cf5ccd into develop Aug 18, 2021
@nlohmann nlohmann deleted the missing_header branch August 18, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.10.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nlohmann @coveralls