Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assertion failure in diagnostics #2866

Merged
merged 5 commits into from
Jul 14, 2021
Merged

Fix assertion failure in diagnostics #2866

merged 5 commits into from
Jul 14, 2021

Conversation

nlohmann
Copy link
Owner

Closes #2838.

@nlohmann nlohmann self-assigned this Jul 12, 2021
@nlohmann nlohmann mentioned this pull request Jul 12, 2021
Closed
5 tasks
@coveralls
Copy link

coveralls commented Jul 12, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling a711e1f on issue2838 into 9426074 on develop.

gregmarr
gregmarr reviewed Jul 12, 2021
View reviewed changes
include/nlohmann/json.hpp Outdated Show resolved Hide resolved
gregmarr
gregmarr reviewed Jul 12, 2021
View reviewed changes
include/nlohmann/json.hpp Outdated Show resolved Hide resolved
@nlohmann nlohmann changed the title Fix assertion failure Fix assertion failure in diagnostics Jul 13, 2021
@nlohmann nlohmann added this to the Release 3.9.2 milestone Jul 14, 2021
@nlohmann nlohmann merged commit c9c5c01 into develop Jul 14, 2021
@nlohmann nlohmann deleted the issue2838 branch July 14, 2021 10:04
@nlohmann nlohmann mentioned this pull request Aug 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmarr gregmarr gregmarr approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🐛 bug fix
Projects
None yet
Milestone
Release 3.10.0
Development

Successfully merging this pull request may close these issues.

Assertion failure when inserting into arrays with JSON_DIAGNOSTICS set
3 participants
@nlohmann @coveralls @gregmarr