Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "#define private public" from tests #2352

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Remove "#define private public" from tests #2352

merged 1 commit into from
Aug 13, 2020

Conversation

nlohmann
Copy link
Owner

This PR adds a macro JSON_PRIVATE_UNLESS_TESTED which is private by default, but can be defined to public when JSON_TESTS_PRIVATE is defined. This is done in all tests that previously used the #define private public hack.

Closes #1985
Closes #913
Closes #43
Related to #2346

@nlohmann nlohmann added this to the Release 3.9.2 milestone Aug 12, 2020
@nlohmann nlohmann self-assigned this Aug 12, 2020
@nlohmann nlohmann mentioned this pull request Aug 12, 2020
Closed
5 tasks
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9d726c2 on private_macro into b888afe on develop.

@nlohmann nlohmann merged commit 8d0aa09 into develop Aug 13, 2020
@nlohmann nlohmann deleted the private_macro branch August 13, 2020 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.10.0
2 participants
@nlohmann @coveralls