Fix 'const' qualifier on bool& has no effect

Thanks, @georgthegreat, for pointing out this issue.
nlohmann · Aug 5, 2022 · b69e4ee · b69e4ee
1 parent 9e1a7c8
commit b69e4ee
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/include/nlohmann/detail/conversions/to_json.hpp b/include/nlohmann/detail/conversions/to_json.hpp
@@ -267,8 +267,10 @@ inline void to_json(BasicJsonType& j, T b) noexcept
     external_constructor<value_t::boolean>::construct(j, b);
 }
 
-template<typename BasicJsonType,
-         enable_if_t<std::is_convertible<const std::vector<bool>::reference&, typename BasicJsonType::boolean_t>::value, int> = 0>
+template < typename BasicJsonType,
+           enable_if_t <
+               std::is_convertible<const std::vector<bool>::reference&, typename BasicJsonType::boolean_t>::value
+               && !std::is_same<std::vector<bool>::reference, typename BasicJsonType::boolean_t&>::value, int > = 0 >
 inline void to_json(BasicJsonType& j, const std::vector<bool>::reference& b) noexcept
 {
     external_constructor<value_t::boolean>::construct(j, static_cast<typename BasicJsonType::boolean_t>(b));

diff --git a/single_include/nlohmann/json.hpp b/single_include/nlohmann/json.hpp
@@ -5500,8 +5500,10 @@ inline void to_json(BasicJsonType& j, T b) noexcept
     external_constructor<value_t::boolean>::construct(j, b);
 }
 
-template<typename BasicJsonType,
-         enable_if_t<std::is_convertible<const std::vector<bool>::reference&, typename BasicJsonType::boolean_t>::value, int> = 0>
+template < typename BasicJsonType,
+           enable_if_t <
+               std::is_convertible<const std::vector<bool>::reference&, typename BasicJsonType::boolean_t>::value
+               && !std::is_same<std::vector<bool>::reference, typename BasicJsonType::boolean_t&>::value, int > = 0 >
 inline void to_json(BasicJsonType& j, const std::vector<bool>::reference& b) noexcept
 {
     external_constructor<value_t::boolean>::construct(j, static_cast<typename BasicJsonType::boolean_t>(b));