fix: silence output when running go test
#88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #87 (comment). |
|
So my suggestion is to close this PR since the test command in CI usually is |
maeb
reviewed
Mar 7, 2024
main_test.go
Outdated
Comment on lines
11
to
20
| stdout_backup := os.Stdout | ||
| stderr_backup := os.Stderr | ||
| os.Stdout = nil | ||
| os.Stderr = nil | ||
|
|
||
| shell := cmd.NewCommand() | ||
| _ = shell.Execute() | ||
|
|
||
| os.Stdout = stdout_backup | ||
| os.Stderr = stderr_backup |
There was a problem hiding this comment.
Suggested change
| stdout_backup := os.Stdout | |
| stderr_backup := os.Stderr | |
| os.Stdout = nil | |
| os.Stderr = nil | |
| shell := cmd.NewCommand() | |
| _ = shell.Execute() | |
| os.Stdout = stdout_backup | |
| os.Stderr = stderr_backup | |
| os.Stdout = nil | |
| os.Stderr = nil | |
| shell := cmd.NewCommand() | |
| _ = shell.Execute() |
Why not keep it simple?
There was a problem hiding this comment.
Added a fixup commit: 0369090
Sorry I didn't read the reply in #87 so ignore this comment. |
maeb
approved these changes
Mar 7, 2024
trym-b
force-pushed
the
fix/silence-output-when-running-go-test
branch
from
0369090
to
492023e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the issue where running
go testwould write to stdout. This was caused bycommit 0c94a34.
The solution is just to redirect
stdoutandstderrtonil.Solves #87