refactor: consolidate workflows #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation To the workflows easier to work with, we should use the `jobs` parameter more often. Especially when the triggers are the same. This makes it easier to inspect the various jobs as they are now mostly in the same workflows. In addition, there should be dependencies between the various jobs, for example, so that the tests run on the actual release. Or not to automatically release if the `lint` job fails. # Changes * `release.yml` is renamed to `main.yml` * The jobs of `test.yml`, and `lint.yml` have now also moved to `main.yml`. * The job `goreleaser` has now been renamed to `Build`, as it reflects what it does better (nothing is actually released, and `goreleaser` is just an implementation detail). # Future work `github-pages` could also potentially be moved to `main.yml`, but because the triggers are different it has been left out for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To the workflows easier to work with, we should
use the
jobsparameter more often. Especiallywhen the triggers are the same.
This makes it easier to inspect the various jobs
as they are now mostly in the same workflows.
In addition, there should be dependencies between
the various jobs, for example, so that the tests
run on the actual release. Or not to automatically release if the
lintjob fails.Changes
release.ymlis renamed tomain.ymltest.yml, andlint.ymlhave now also moved tomain.yml.goreleaserhas now been renamed toBuild, as it reflects what it does better (nothing is actually released, andgoreleaseris just an implementation detail).Future work
github-pagescould also potentially be moved tomain.yml, but because the triggers are different it has been left out for now.