refactor: rename testdata dir
#145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a convention in `GO` to name the test data directory `testdata`, not `test-data`. This convention comes from the part of `go help packages` that says: ``` Directory and file names that begin with "." or "_" are ignored by the go tool, as are directories named "testdata". ```
trym-b
force-pushed
the
refactor/rename-testdata-dir
branch
from
f51fffb
to
2e3e700
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a convention in
GOto name the testdata directory
testdata, nottest-data. Thisconvention comes from the part of
go help packagesthat says: