fix: use integer parameter #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maeb
reviewed
Apr 9, 2024
There was a problem hiding this comment.
Maybe this PR should change it everywhere it is used: https://github.com/search?q=repo%3Anlnwa%2Fwarchaeology%20flag.CompressionLevel&type=code
trym-b
force-pushed
the
fix/compression-level-as-int-not-bool
branch
from
c5f29bf
to
a1f9ece
Compare
maeb
approved these changes
Apr 10, 2024
The compression level parameter was a `boolean` instead of an `int`. This commit fixes this. Closes #132
maeb
force-pushed
the
fix/compression-level-as-int-not-bool
branch
from
a1f9ece
to
cc91a32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compression level parameter was a
booleaninstead of an
int. This commit fixes this.Closes #132