Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for Result and Stats #129

Merged
merged 4 commits into from
Apr 8, 2024
Merged

test: add test for Result and Stats #129

merged 4 commits into from
Apr 8, 2024

Conversation

trym-b
Copy link
Contributor

@trym-b trym-b commented Apr 8, 2024

Best reviewed commit by commit

Copy link

@andrbo andrbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from refactor/walk to main April 8, 2024 09:22
This commit moves the functions from the
`filewalker.go` file to the `helpers.go` file.
This is done to make the `filewalker.go` file more
readable.
This commit moves the `Results` type and its
functions to a separate file. This is done to make
the code more readable and maintainable.
Regression tests helps with improve developer
experience and ensure that the code is working as
expected.
Similar to the previous commit, but instead
testing the `Result` type and its functions.
@trym-b trym-b merged commit 06d8944 into main Apr 8, 2024
8 checks passed
@trym-b trym-b deleted the refactor/walk-part-2 branch April 8, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants