fix: silence benchmark output #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since commit d8d316a the benchmark results of `BenchmarkReadFileWithError` are no longer present. `BenchmarkReadFileWithError` has not been deleted, and it seems like some of the output printed to the benchmark result file causes `github-action-benchmark` to fail finding this result. The reason why commit d8d316a triggered this error is because it added the required `lfs` checkout so that the test-data was cloned correctly. As a workaround, this commit silences the output of the benchmark `BenchmarkReadFileWithError`.
|
This url points to a benchmark result that contains the missing benchmark as a test in a separate repo: trym-b@45fe0da |
andrbo
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit
d8d316a the
benchmark results of
BenchmarkReadFileWithErrorare no longer present.
BenchmarkReadFileWithErrorhas not been deleted, and it seems like some of the output printed tothe benchmark result file causes
github-action-benchmarkto fail finding thisresult.
The reason why commit
d8d316a triggered this error is because it added the required
lfscheckout so that the test-data was cloned
correctly.
As a workaround, this commit silences the output
of the benchmark
BenchmarkReadFileWithError.