Support WARC extension fields from Browsertrix #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maeb
changed the title
|
Need to rename |
maeb
force-pushed
the
feat/extension-fields
branch
2 times, most recently
from
cbf6d83
to
cccbe4c
Compare
To preserve the case of field-names produced by Browsertrix, this commit adds the fields WARC-Page-ID, WARC-JSON-Metadata and WARC-Resource-Type to the list of known header fields. gowarc can handle unknown fields but normalizes their field-names to title-case. The WARC specification allows for extension fields in the WARC header.
Adds some more test cases.
maeb
force-pushed
the
feat/extension-fields
branch
from
cccbe4c
to
d845893
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the fields WARC-Page-ID, WARC-Resource-Type and WARC-JSON-Metadata to the list of known fields such that processing of WARC header fields produced by browsertrix preserves the casing of the field names.