Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore . directory #11

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Ignore . directory #11

merged 2 commits into from
Dec 6, 2021

Conversation

adyatlov
Copy link
Contributor

@adyatlov adyatlov commented Dec 3, 2021

Fix for the issue #10

@nlepage
Copy link
Owner

nlepage commented Dec 4, 2021

Hi @adyatlov
Thank you for your contribution, I'll review and merge it on Monday.
Cheers

@nlepage nlepage self-assigned this Dec 6, 2021
@nlepage nlepage added the bug Something isn't working label Dec 6, 2021
nlepage
nlepage approved these changes Dec 6, 2021
View reviewed changes
Copy link
Owner

@nlepage nlepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adyatlov
I changed your test to actually check that fs.WalkDir works, instead of just checking it doesn't fall in an infinite loop.
Thanks again for your contribution!

@nlepage nlepage merged commit 57c0c14 into nlepage:main Dec 6, 2021
@nlepage nlepage mentioned this pull request Dec 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlepage nlepage nlepage approved these changes

Assignees

@nlepage nlepage

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adyatlov @nlepage