Upgraded to Api25 and got it to work with https://socketio-chat.now.sh/ #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 20, 2017 01:47
…et.io#2823 2. Android Studio 2.3.0-beta4, Api25, gradle 3.3 changes. 3. works with Pixel XL emulator, Api23
15 tasks
|
Hi, thanks for the PR ! Looks great ❤️ It looks this is ready to merge ? |
|
@nkzawa yes, I 'm done for now if you want to merge it into your repo. And then I will sync my master with your master. I 'm using a beta version (2.3.0-b4) of Android Studio. Hope thats not too much of an issue for a sample app like this. Once the final release of 2.3.0 is out I can send you another PR. Not sure of the timeline on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details here: lakamsani@5a4a514
Also see socketio/socket.io#2823