Skip to content

Commit

Permalink
dmaengine: at_xdmac: change block increment addressing mode
Browse files Browse the repository at this point in the history
The addressing mode we were using was not only incrementing the address at
each microblock, but also at each data boundary, which was severely slowing
the transfer, without any benefit since we were not using the data stride.

Switch to the micro block increment only in order to get back to an
acceptable performance level.

Signed-off-by: Maxime Ripard <[email protected]>
Signed-off-by: Ludovic Desroches <[email protected]>
Fixes: 6007ccb ("dmaengine: xdmac: Add interleaved transfer support")
Cc: [email protected] openbmc#4.2
Signed-off-by: Vinod Koul <[email protected]>
  • Loading branch information
mripard authored and nkskjames committed Jan 13, 2016
1 parent e608fef commit d98f6cb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/dma/at_xdmac.c
Original file line number Diff line number Diff line change
Expand Up @@ -875,14 +875,14 @@ at_xdmac_interleaved_queue_desc(struct dma_chan *chan,

if (xt->src_inc) {
if (xt->src_sgl)
chan_cc |= AT_XDMAC_CC_SAM_UBS_DS_AM;
chan_cc |= AT_XDMAC_CC_SAM_UBS_AM;
else
chan_cc |= AT_XDMAC_CC_SAM_INCREMENTED_AM;
}

if (xt->dst_inc) {
if (xt->dst_sgl)
chan_cc |= AT_XDMAC_CC_DAM_UBS_DS_AM;
chan_cc |= AT_XDMAC_CC_DAM_UBS_AM;
else
chan_cc |= AT_XDMAC_CC_DAM_INCREMENTED_AM;
}
Expand Down

0 comments on commit d98f6cb

Please sign in to comment.