Skip to content

feat: add Devin ACP provider support - #3

Merged
nkowne63 merged 1 commit into
mainfrom
codex/devin-acp-clean
Jun 26, 2026
Merged

feat: add Devin ACP provider support#3
nkowne63 merged 1 commit into
mainfrom
codex/devin-acp-clean

Conversation

@nkowne63

Copy link
Copy Markdown
Owner

Summary

  • add Devin ACP as an external-process model provider
  • wire Devin ACP into provider discovery, auth/status reporting, runtime resolution, setup/model switching, and delegation override validation
  • add tests covering Devin ACP provider registration and credential/status behavior

Validation

  • venv/bin/python -m pytest tests/hermes_cli/test_api_key_providers.py -q171 passed, 3 warnings
  • venv/bin/hermes chat -q 'Reply with exactly OK and nothing else.' --provider devin-acp --ignore-user-config --source tool -QOK

Notes

This replaces the earlier oversized PR that was accidentally based on an old/stacked branch. This branch is rebuilt directly on the synced fork main / upstream origin/main and contains only the Devin ACP provider change.

@github-actions

Copy link
Copy Markdown

🔎 Lint report: codex/devin-acp-clean vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 11458 on HEAD, 11455 on base (🆕 +3)

🆕 New issues (3):

Rule Count
unresolved-attribute 2
invalid-method-override 1
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [unresolved-attribute] unresolved-attribute: Unresolved attribute `_credits_session_start_micros` on type `AIAgent`
run_agent.py:3002: [unresolved-attribute] unresolved-attribute: Object of type `Self@get_credits_spent_micros` has no attribute `_credits_session_start_micros`
plugins/model-providers/devin-acp/__init__.py:15: [invalid-method-override] invalid-method-override: Invalid override of method `fetch_models`: Definition is incompatible with `ProviderProfile.fetch_models`

✅ Fixed issues (1):

Rule Count
invalid-assignment 1
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [invalid-assignment] invalid-assignment: Object of type `None` is not assignable to attribute `_credits_session_start_micros` of type `int`

Unchanged: 6014 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@nkowne63
nkowne63 merged this pull request into main Jun 26, 2026
25 of 27 checks passed
nkowne63 pushed a commit that referenced this pull request Aug 5, 2026
… (re-review #3)

The last_activity_at/description/provenance columns already live in
SCHEMA_SQL and the column reconciler; existing DBs heal via the
reconciler, but the version stamp must advance so downgrade/upgrade
tooling sees the new layout. No version-literal test assertions exist
(tests compare against the imported constant).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant