Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
message.part.updatedevents arrive without explicit delta events.message.part.deltais followed by amessage.part.updatedthat includes the same content.Description
textSnapshotsmap to track the last full text for each part viatextSnapshots.textDeltahelper that computes the incremental delta from the previous snapshot and updates the snapshot.textandreasoningparts in themessage.part.updatedflow usingtextDelta.message.part.deltahandling to set the snapshot (textSnapshots.set) when full text is available to avoid replaying the same content.packages/opencode/test/acp/event-subscription.test.tsto verify that text chunks are emitted formessage.part.updatedand that duplicate chunks are not produced when a delta is followed by an updated event.Testing
packages/opencode/test/acp/event-subscription.test.tsviayarn testfor the package and the new tests passed.emits text chunks from message.part.updated when delta events are absentanddoes not duplicate chunks when message.part.delta is followed by message.part.updated) succeeded as part of the suite.Codex Task