Skip to content

Fix F# option date index member selection #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nkosi23 merged 1 commit into from
Feb 4, 2026
Merged

Fix F# option date index member selection #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/DocumentDbTests/Indexes/computed_indexes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ index definition was executed in postgresql.

StoreOptions(_ =>
{
_.RegisterFSharpOptionValueTypes();
var columns = new Expression<Func<Target, object>>[]
{
x => x.FSharpDateOption,
Expand Down
16 changes: 16 additions & 0 deletions src/Marten/StoreOptions.MemberFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,14 @@ public bool TryResolve(IQueryableMember parent, StoreOptions options, MemberInfo
return false;
}

if (valueType.OuterType.IsGenericType
&& valueType.OuterType.GetGenericTypeDefinition() == typeof(FSharpOption<>)
&& isSpecialFSharpOptionDateType(valueType.SimpleType))
{
member = null;
return false;
}

Type baseType;
if (valueType.OuterType.IsGenericType && valueType.OuterType.GetGenericTypeDefinition() == typeof(FSharpOption<>))
{
Expand All @@ -170,4 +178,12 @@ public bool TryResolve(IQueryableMember parent, StoreOptions options, MemberInfo

return true;
}

private static bool isSpecialFSharpOptionDateType(Type simpleType)
{
return simpleType == typeof(DateTime)
|| simpleType == typeof(DateTimeOffset)
|| simpleType == typeof(DateOnly)
|| simpleType == typeof(TimeOnly);
}
}
Loading