🐛 Prevent empty key or value in SetFieldKey function

nkmr-jp · Oct 27, 2023 · 3d4be87 · 3d4be87
1 parent 7fb5dba
commit 3d4be87
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/options.go b/options.go
@@ -188,6 +188,9 @@ func SetOmitKeys(key ...Key) {
 
 // SetFieldKey is changes the key of the default field.
 func SetFieldKey(key Key, val string) {
+	if key == "" || val == "" {
+		return
+	}
 	fieldKeys[key] = val
 }
 

diff --git a/options_test.go b/options_test.go
@@ -70,6 +70,8 @@ func TestSetLevelByString(t *testing.T) {
 func TestSetFieldKey(t *testing.T) {
 	SetFieldKey(FunctionKey, "func")
 	SetFieldKey(StacktraceKey, "stack_trace")
+	SetFieldKey(CallerKey, "")
+	SetFieldKey("", "abc")
 	assert.Equal(t,
 		map[Key]string{
 			FunctionKey:   "func",