Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Settings to XML While Preserving Existing User Values #33

Closed
Tracked by #35
nkasco opened this issue Jan 16, 2023 · 0 comments · Fixed by #37
Closed
Tracked by #35

Add New Settings to XML While Preserving Existing User Values #33

nkasco opened this issue Jan 16, 2023 · 0 comments · Fixed by #37
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nkasco
Copy link
Owner

nkasco commented Jan 16, 2023

The Settings.xml is intentionally not overwritten between updates so that we don't accidentally wipe out the user's setting values... However, when new settings are introduced this creates a gap where the XML is never updated.

Create a new method that adds non-existent settings to the XML with their default values, while preserving existing values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant