-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getSourceFromBrowser for CSS documents #26
base: master
Are you sure you want to change the base?
Conversation
to be used for developing CSS Editing unit tests.
text = sheet.ownerNode.innerText; | ||
} | ||
// if it was not already 'reloaded' | ||
if (!sheet.disabled && sheet.href === msg.params.url) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments make it sound like these blocks are mutually exclusive, so shouldn't this be else if (...)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually yes, I'll change that.
I'm seeing new unit test fail: should push changes through browser connection
|
Done with code review. |
It seems the failure is related to getStylesheetText not retrieving the code from the browser side. I'm not able to make it fail even running on different browsers (IE, Firefox and Chrome). Which browser are you using to run it? |
I'm on Windows 7 and my default browser (where tests are being run) is Firefox. |
just a couple of small changes.
Added a couple of changes to the implementation of getStylesheetText. Tests are passing in Firefox and Chrome on my environment (Windows 8) against master branch of Brackets. Could you please check them now? Thanks! |
We're trying to finish up Brackets 1.0 this week and next week, so not sure when I'll get to it. |
I'm still seeing same error on Win7/Firefox, which I'm also seeing in pull request #28 |
I verified that tests pass on MacOSX 10.8/Safari. |
Adds
LiveCSSDocument.getSourceFromBrowser()
by addinggetStylesheetText()
to protocol layer to be used as the underlying infrastructure for CSS Editing unit tests. This PR also includes an initial test for CSS Editing.