Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport OpenSSL::SSL::SSLSocket#getbyte #139

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Backport OpenSSL::SSL::SSLSocket#getbyte #139

merged 1 commit into from
Jun 15, 2022

Conversation

tenderlove
Copy link
Contributor

This backports the getbyte method which was added in this PR:

ruby/openssl#438

We only add the method to SSLSocket if the method isn't already defined.
I was able to test this with the following program:

require 'rubygems'
require 'mqtt'

client = MQTT::Client.connect(
  host: "test.mosquitto.org",
  port: 8883,
  ssl: true
)

client.get

Fixes #135

This backports the getbyte method which was added in this PR:

  ruby/openssl#438

We only add the method to SSLSocket if the method isn't already defined.
I was able to test this with the following program:

```ruby
require 'rubygems'
require 'mqtt'

client = MQTT::Client.connect(
  host: "test.mosquitto.org",
  port: 8883,
  ssl: true
)

client.get
```

Fixes njh#135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSL connection failing due to optimisations in PR #134
2 participants