Skip to content

fix: sys::signal::SaFlags_t definition on redox#2751

Merged
SteveLauC merged 1 commit intonix-rust:masterfrom
xtqqczze:GH2750
Mar 16, 2026
Merged

fix: sys::signal::SaFlags_t definition on redox#2751
SteveLauC merged 1 commit intonix-rust:masterfrom
xtqqczze:GH2750

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze commented Mar 9, 2026 •
edited
Loading

Unblock redox build

  • Fix sys::signal::SaFlags_t definition
  • Update rust crate libc to v0.2.183

Fix #2750

@xtqqczze xtqqczze mentioned this pull request Mar 9, 2026
Merged
@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Mar 9, 2026 •
edited
Loading

I had to insert additional as casts due to a mistake in libc, they can be removed once rust-lang/libc#5009 is released.

@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Mar 11, 2026

@JohnTitor Maybe it would be useful if libc could expose a __sigaction_flags_t type.

@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Mar 13, 2026

@SteveLauC the issue this fixes is currently blocking CI

SteveLauC
SteveLauC approved these changes Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this

@SteveLauC SteveLauC added this pull request to the merge queue Mar 16, 2026
Merged via the queue into nix-rust:master with commit 0708c8c Mar 16, 2026
43 of 44 checks passed
@xtqqczze xtqqczze mentioned this pull request Mar 16, 2026
Open
1 task
@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Mar 16, 2026

@SteveLauC this block using libc v0.2.183, could you cut a new release please.

@xtqqczze xtqqczze deleted the GH2750 branch March 16, 2026 12:12
@SteveLauC
Copy link
Copy Markdown
Member

SteveLauC commented Mar 17, 2026

@SteveLauC this block using libc v0.2.183, could you cut a new release please.

Sure

@xtqqczze xtqqczze mentioned this pull request Apr 1, 2026
Open
@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Apr 1, 2026

@SteveLauC it's still blocking with libc v0.2.184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveLauC SteveLauC SteveLauC approved these changes

+1 more reviewer

@jackpot51 jackpot51 jackpot51 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Redox build failure with latest libc: SaFlags::bits() type mismatch (u64 vs i32)

3 participants

@xtqqczze @SteveLauC @jackpot51