Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys::termios: adding ControlFlags::ECHO #2420

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devnexen
Copy link
Contributor

enable echoing on input characters.

while at it with this new flag, fixing pty open_tty_pair test for solarish. While the test_write_ptty_pair passes, the test_read_ptty_pair fails when filling the master buffer.

Thus, we disable canonical and echo modes on the slave.

@devnexen devnexen force-pushed the fix_pty_solaris_test branch 3 times, most recently from 1fe874f to d312f70 Compare May 30, 2024 20:59
While the test_write_ptty_pair passes, the test_read_ptty_pair fails
when filling the master buffer.

Thus, we disable canonical and echo modes on the slave.
Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi

adding ControlFlags::ECHO

Is this cflag available on Solarish? Document from Oracle does not have it.

the test_read_ptty_pair fails when filling the master buffer.

Would you like to show me the error message shown on Solarish systems and why we need that special setup on them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants