Merged
Conversation
Contributor
Author
|
Blocked on #1876 |
JonathanWoollett-Light
force-pushed
the
epoll-timeout
branch
from
84260f1 to
64e3af6
Compare
Member
|
Can you please rebase to resolve the conflict? |
JonathanWoollett-Light
force-pushed
the
epoll-timeout
branch
from
64e3af6 to
0253dfa
Compare
Contributor
Author
Rebased. |
asomers
requested changes
Nov 23, 2023
JonathanWoollett-Light
force-pushed
the
epoll-timeout
branch
4 times, most recently
from
b79c2b8 to
3df6d9d
Compare
asomers
requested changes
Nov 24, 2023
Member
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
Looks good. Could you please add a CHANGELOG?
JonathanWoollett-Light
force-pushed
the
epoll-timeout
branch
from
3df6d9d to
edb4cf4
Compare
Contributor
Author
Added. |
asomers
approved these changes
Nov 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
Makes the
PollTimeoutfrom #1876 generic so it can be used byEpoll.Checklist:
CONTRIBUTING.md