Skip to content

Commit

Permalink
Fix the build with -Zdirect-minimal-versions (#2453)
Browse files Browse the repository at this point in the history
The difference between -Zminimal-versions and -Zdirect-minimal-versions
is subtle.  But the important point is that with the former, a new
release published by one of our dependencies can cause our CI to fail.
With the latter, it cannot.  That's why I think it's better to test with
the latter.
  • Loading branch information
asomers committed Jun 24, 2024
1 parent 95bedfd commit d98b849
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ jobs:
uses: dtolnay/rust-toolchain@nightly

- name: setup
run: cargo update -Zminimal-versions
run: cargo update -Zdirect-minimal-versions

- name: check
run: cargo check
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ targets = [

[dependencies]
libc = { version = "0.2.155", features = ["extra_traits"] }
bitflags = "2.3.1"
bitflags = "2.3.3"
cfg-if = "1.0"
pin-utils = { version = "0.1.0", optional = true }
memoffset = { version = "0.9", optional = true }
Expand Down

0 comments on commit d98b849

Please sign in to comment.