Skip to content

nixcord: add Equibop and Equicord support#2016

Merged
0xda157 merged 4 commits intonix-community:masterfrom
make-42:nixcord-equibop-equicord-support
Nov 25, 2025
Merged

nixcord: add Equibop and Equicord support#2016
0xda157 merged 4 commits intonix-community:masterfrom
make-42:nixcord-equibop-equicord-support

Conversation

@make-42
Copy link
Copy Markdown
Contributor

@make-42 make-42 commented Nov 22, 2025

Adds Equibop and Equicord support to the nixcord module.


@stylix-automation stylix-automation bot added the topic: modules /modules/ subsystem label Nov 22, 2025
Copy link
Copy Markdown
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. can you add testbed(s) for this
  2. the nested mkMerge/mkIfs are getting very hard to parse, it would be nice if the logic could be extracted to make it more readable (in a separate commit) (not required)

@make-42
Copy link
Copy Markdown
Contributor Author

make-42 commented Nov 22, 2025

sure

@make-42
Copy link
Copy Markdown
Contributor Author

make-42 commented Nov 22, 2025

For 1. though, since nixcord isn't imported by stylix I don't think I'm actually able to pull the nixcord options in to use in a testbed

@0xda157
Copy link
Copy Markdown
Contributor

0xda157 commented Nov 22, 2025

For 1. though, since nixcord isn't imported by stylix I don't think I'm actually able to pull the nixcord options in to use in a testbed

feel free to add nixcord as a dev input, #1994 might be a helpful example.

@make-42
Copy link
Copy Markdown
Contributor Author

make-42 commented Nov 22, 2025

sure

@make-42
Copy link
Copy Markdown
Contributor Author

make-42 commented Nov 22, 2025

adding nixcord as a dev input doesn't grant me access to it from a testbed for some reason

@make-42
Copy link
Copy Markdown
Contributor Author

make-42 commented Nov 22, 2025

image

@make-42
Copy link
Copy Markdown
Contributor Author

make-42 commented Nov 22, 2025

having added this to flake/dev/flake.nix

image

and having run
nix flake update nixcord
in that dir

@make-42
Copy link
Copy Markdown
Contributor Author

make-42 commented Nov 22, 2025

am i missing anything?

@make-42
Copy link
Copy Markdown
Contributor Author

make-42 commented Nov 22, 2025

image

i get the following error

@make-42
Copy link
Copy Markdown
Contributor Author

make-42 commented Nov 22, 2025

oh and i also did add it to stylix/testbed/default.nix
image

@make-42
Copy link
Copy Markdown
Contributor Author

make-42 commented Nov 22, 2025

i did

@0xda157
Copy link
Copy Markdown
Contributor

0xda157 commented Nov 22, 2025

image

i get the following error

the testbed needs to be called nixcord-equibop for nixcord to be imported

@make-42
Copy link
Copy Markdown
Contributor Author

make-42 commented Nov 22, 2025

that does indeed work

@stylix-automation stylix-automation bot added topic: testbed Testbed changes topic: flake /flake.nix, /flake.lock, and /flake/ subsystems topic: stylix /stylix/ subsystem labels Nov 22, 2025
@make-42
Copy link
Copy Markdown
Contributor Author

make-42 commented Nov 22, 2025

for some reason the option is now allowed to be enabled but the testbed doesn't have the package

@make-42
Copy link
Copy Markdown
Contributor Author

make-42 commented Nov 22, 2025

(i probably just forgot to enable nixcord)

@make-42 make-42 force-pushed the nixcord-equibop-equicord-support branch 3 times, most recently from 5fe8770 to 5b6a41f Compare November 22, 2025 23:03
Copy link
Copy Markdown
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@make-42
Copy link
Copy Markdown
Contributor Author

make-42 commented Nov 22, 2025

tiny typo i've got left to fix

@make-42 make-42 force-pushed the nixcord-equibop-equicord-support branch from 5b6a41f to edd6086 Compare November 22, 2025 23:07
@make-42
Copy link
Copy Markdown
Contributor Author

make-42 commented Nov 22, 2025

now it should be all good

@make-42 make-42 force-pushed the nixcord-equibop-equicord-support branch 3 times, most recently from 9aec6c7 to 905b411 Compare November 22, 2025 23:10
@make-42
Copy link
Copy Markdown
Contributor Author

make-42 commented Nov 22, 2025

screenshot from the testbed: image

@make-42
Copy link
Copy Markdown
Contributor Author

make-42 commented Nov 22, 2025

actually new error with the new flake file:
image

nixcord: add equibop and equicord testbeds with better logic

nixcord: add equibop and equicord testbeds with better logic

nixcord: add equibop and equicord testbeds with better logic

nixcord: add equibop and equicord testbeds with better logic

nixcord: add equibop and equicord testbeds with better logic

nixcord: add equibop and equicord testbeds with better logic

nixcord: add equibop and equicord testbeds with better logic

nixcord: add equibop and equicord testbeds with better logic

nixcord: add equibop and equicord testbeds with better logic

nixcord: add equibop and equicord testbeds with better logic

nixcord: add equibop and equicord testbeds with better logic

nixcord: add equibop and equicord testbeds with better logic

nixcord: add equibop and equicord testbeds with better logic

nixcord: add equibop and equicord testbeds with better logic

nixcord: add equibop and equicord testbeds with better logic

nixcord: add equibop and equicord testbeds with better logic

nixcord: add equibop and equicord testbeds with better logic
@make-42 make-42 force-pushed the nixcord-equibop-equicord-support branch from 905b411 to 8c25a43 Compare November 22, 2025 23:14
@0xda157
Copy link
Copy Markdown
Contributor

0xda157 commented Nov 22, 2025

seems like nixpkgs.config.allowUnfreePredicate isn't applying to the buildbot runners (which is expected). @zowoq is there any way around this so we can still build our testbeds that have unfree packages?

@zowoq
Copy link
Copy Markdown

zowoq commented Nov 22, 2025

seems like nixpkgs.config.allowUnfreePredicate isn't applying to the buildbot runners (which is expected)

Why is that expected?

If allowUnfree is set on a package buildbot should respect it.

@0xda157
Copy link
Copy Markdown
Contributor

0xda157 commented Nov 23, 2025

seems like nixpkgs.config.allowUnfreePredicate isn't applying to the buildbot runners (which is expected)

Why is that expected?

If allowUnfree is set on a package buildbot should respect it.

nvm I'm pretty sure it isn't expected, still an issue regardless.

Copy link
Copy Markdown
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like nixpkgs.config.allowUnfreePredicate isn't applying to the buildbot runners (which is expected)

Why is that expected?
If allowUnfree is set on a package buildbot should respect it.

nvm I'm pretty sure it isn't expected, still an issue regardless.

nvm this is happening on gh actions too, it's an issue with the config. @make-42 you'll have to remove testbeds from this pr and I'll work on resolving the issue in a follow up (it requires being able to access inputs from the testbed).

@make-42
Copy link
Copy Markdown
Contributor Author

make-42 commented Nov 23, 2025

okay, i'll revert the testbeds

@make-42
Copy link
Copy Markdown
Contributor Author

make-42 commented Nov 23, 2025

Should be good to go

@pastadudes
Copy link
Copy Markdown

LGTM and works for me!
thank you people

Copy link
Copy Markdown
Contributor

@Flameopathic Flameopathic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's there looks good, and I like the abstraction (but the name is a little unclear; maybe something like writeConfigFile?). Would love to see that testbed implemented. Not sure why there are any issues with this testbed that aren't present in NixVim etc.

@0xda157
Copy link
Copy Markdown
Contributor

0xda157 commented Nov 24, 2025

Would love to see that testbed implemented. Not sure why there are any issues with this testbed that aren't present in NixVim etc.

because discord is unfree and nixcord uses their own package, not the one in nixpkgs.

@0xda157 0xda157 merged commit b5072c5 into nix-community:master Nov 25, 2025
8 checks passed
@trueNAHO
Copy link
Copy Markdown
Member

trueNAHO commented Nov 25, 2025

seems like nixpkgs.config.allowUnfreePredicate isn't applying

Is this the same problem as in #1662 (comment)?

Mikilio pushed a commit to Mikilio/stylix that referenced this pull request Nov 27, 2025
Link: nix-community#2016

Reviewed-by: 0xda157 <da157@voidq.com>
Tested-by: https://github.com/pastadudes
Reviewed-by: Flameopathic <flameopathic@gmail.com>
psyclyx pushed a commit to psyclyx/stylix that referenced this pull request Dec 1, 2025
Link: nix-community#2016

Reviewed-by: 0xda157 <da157@voidq.com>
Tested-by: https://github.com/pastadudes
Reviewed-by: Flameopathic <flameopathic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: flake /flake.nix, /flake.lock, and /flake/ subsystems topic: modules /modules/ subsystem topic: stylix /stylix/ subsystem topic: testbed Testbed changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants