nixcord: add Equibop and Equicord support#2016
Conversation
0xda157
left a comment
There was a problem hiding this comment.
- can you add testbed(s) for this
- the nested mkMerge/mkIfs are getting very hard to parse, it would be nice if the logic could be extracted to make it more readable (in a separate commit) (not required)
|
sure |
|
For 1. though, since nixcord isn't imported by stylix I don't think I'm actually able to pull the nixcord options in to use in a testbed |
feel free to add nixcord as a dev input, #1994 might be a helpful example. |
|
sure |
|
adding nixcord as a dev input doesn't grant me access to it from a testbed for some reason |
|
am i missing anything? |
|
i did |
|
that does indeed work |
|
for some reason the option is now allowed to be enabled but the testbed doesn't have the package |
|
(i probably just forgot to enable nixcord) |
5fe8770 to
5b6a41f
Compare
|
tiny typo i've got left to fix |
5b6a41f to
edd6086
Compare
|
now it should be all good |
9aec6c7 to
905b411
Compare
nixcord: add equibop and equicord testbeds with better logic nixcord: add equibop and equicord testbeds with better logic nixcord: add equibop and equicord testbeds with better logic nixcord: add equibop and equicord testbeds with better logic nixcord: add equibop and equicord testbeds with better logic nixcord: add equibop and equicord testbeds with better logic nixcord: add equibop and equicord testbeds with better logic nixcord: add equibop and equicord testbeds with better logic nixcord: add equibop and equicord testbeds with better logic nixcord: add equibop and equicord testbeds with better logic nixcord: add equibop and equicord testbeds with better logic nixcord: add equibop and equicord testbeds with better logic nixcord: add equibop and equicord testbeds with better logic nixcord: add equibop and equicord testbeds with better logic nixcord: add equibop and equicord testbeds with better logic nixcord: add equibop and equicord testbeds with better logic nixcord: add equibop and equicord testbeds with better logic
905b411 to
8c25a43
Compare
|
seems like |
Why is that expected? If allowUnfree is set on a package buildbot should respect it. |
nvm I'm pretty sure it isn't expected, still an issue regardless. |
0xda157
left a comment
There was a problem hiding this comment.
seems like
nixpkgs.config.allowUnfreePredicateisn't applying to the buildbot runners (which is expected)Why is that expected?
If allowUnfree is set on a package buildbot should respect it.nvm I'm pretty sure it isn't expected, still an issue regardless.
nvm this is happening on gh actions too, it's an issue with the config. @make-42 you'll have to remove testbeds from this pr and I'll work on resolving the issue in a follow up (it requires being able to access inputs from the testbed).
|
okay, i'll revert the testbeds |
|
Should be good to go |
|
LGTM and works for me! |
Flameopathic
left a comment
There was a problem hiding this comment.
What's there looks good, and I like the abstraction (but the name is a little unclear; maybe something like writeConfigFile?). Would love to see that testbed implemented. Not sure why there are any issues with this testbed that aren't present in NixVim etc.
because discord is unfree and nixcord uses their own package, not the one in nixpkgs. |
Is this the same problem as in #1662 (comment)? |
Link: nix-community#2016 Reviewed-by: 0xda157 <da157@voidq.com> Tested-by: https://github.com/pastadudes Reviewed-by: Flameopathic <flameopathic@gmail.com>
Link: nix-community#2016 Reviewed-by: 0xda157 <da157@voidq.com> Tested-by: https://github.com/pastadudes Reviewed-by: Flameopathic <flameopathic@gmail.com>







Adds Equibop and Equicord support to the nixcord module.