Skip to content

ci: request-reviewers: do not request PR author#1885

Merged
0xda157 merged 1 commit intonix-community:masterfrom
trueNAHO:ci-request-reviewers-do-not-request-pr-author
Sep 6, 2025
Merged

ci: request-reviewers: do not request PR author#1885
0xda157 merged 1 commit intonix-community:masterfrom
trueNAHO:ci-request-reviewers-do-not-request-pr-author

Conversation

@trueNAHO
Copy link
Copy Markdown
Member

@trueNAHO trueNAHO commented Sep 5, 2025

Closes: https://github.com/nix-community/stylix/issues/1867

I suggest optimistically closing #1867 with this PR. We can re-open it, if the issue is still not resolved.

This PR_AUTHOR filtering was accidentally removed in the following patch:

From c81f587ce7a796b4bbfb7792ae42b12e1446fb29 Mon Sep 17 00:00:00 2001
From: NAHO <90870942+trueNAHO@users.noreply.github.com>
Date: Thu, 24 Jul 2025 20:24:55 +0200
Subject: [PATCH 3/5] ci: ping-maintainers: overhaul implementation

---
 .github/workflows/ping-maintainers.yml | 79 +++++++++++++-------------
 1 file changed, 39 insertions(+), 40 deletions(-)

diff --git a/.github/workflows/ping-maintainers.yml b/.github/workflows/ping-maintainers.yml
index f986010..fab3d6c 100644
--- a/.github/workflows/ping-maintainers.yml
+++ b/.github/workflows/ping-maintainers.yml
[...]
         env:
-          PR_AUTHOR: ${{ github.event.pull_request.user.login }}
[...]
-              # Do not request the original author or already requested
-              # reviewers.
-              if [[
-                "$gh_id" == "$PR_AUTHOR" || \
-                jq "index(\"$gh_id\") != null" <<<"$existing_reviewers"
-              ]]; then
-                  continue
-              fi

-- #1053 (review)


@0xda157 0xda157 merged commit f6e9a1b into nix-community:master Sep 6, 2025
7 checks passed
stylix-automation bot pushed a commit that referenced this pull request Sep 6, 2025
Link: #1885
Closes: #1867

Reviewed-by: awwpotato <awwpotato@voidq.com>
(cherry picked from commit f6e9a1b)
@stylix-automation
Copy link
Copy Markdown
Contributor

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the has: port to stable This has been backported to the latest stable branch label Sep 6, 2025
0xda157 pushed a commit that referenced this pull request Sep 6, 2025
Link: #1885
Closes: #1867

Reviewed-by: awwpotato <awwpotato@voidq.com>
(cherry picked from commit f6e9a1b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has: port to stable This has been backported to the latest stable branch topic: ci /.github/ subsystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants