ci: remove 'Notify Maintainers' section from PR template#1856
ci: remove 'Notify Maintainers' section from PR template#1856trueNAHO merged 1 commit intonix-community:masterfrom
Conversation
There was a problem hiding this comment.
I thought the same, but did not submit a PR because manual pinging is still desirable when more than
people should be notified, although this has AFAIK never occurred. Manual pining is still great for non-module changes or modules without explicit maintainers.
Should we keep this "Notify Maintainers" section or just require manual pinging inside the PR description, as in:
<DESCRIPTION>
CC: @awwpotato, @danth, @trueNAHO
<!-- Describe your PR above, following Stylix commit conventions. -->
---
## Submission Checklist
This was done to prevent large treewide changes from pinging many people. If we ever get a module with more than five maintainers we can always increase the limit, and module maintainers can always be manually pinged but prompting pr authors to notify maintainers for every pr seems unnecessary.
Consider that the "notify maintainers" section only instructs the author to ping maintainers from the
I think we don't need to keep the section for the rare cases where manually pinging people is required. |
danth
left a comment
There was a problem hiding this comment.
I think it's good to simplify the contribution process as much as possible by removing this.
Having a module with more than 5 maintainers seems unlikely - and would probably indicate that some of those maintainers are no longer active.
|
Successfully created backport PR for |
Remove the explicit 'Submission Checklist' header since it is the only header in the template section after applying commits e544f6e ("ci: visually distinguish user description from PR template content (nix-community#1802)") and 2355da4 ("ci: remove 'Notify Maintainers' section from PR template (nix-community#1856)"). This simplifies the template to its essentials, while keeping the descriptive checklist code comment.
Remove the explicit 'Submission Checklist' header since it is the only header in the template section after applying commits e544f6e ("ci: visually distinguish user description from PR template content (#1802)") and 2355da4 ("ci: remove 'Notify Maintainers' section from PR template (#1856)"). This simplifies the template to its essentials, while keeping the descriptive checklist code comment. Link: #1869 Approved-by: Daniel Thwaites <danth@danth.me>
Remove the explicit 'Submission Checklist' header since it is the only header in the template section after applying commits e544f6e ("ci: visually distinguish user description from PR template content (#1802)") and 2355da4 ("ci: remove 'Notify Maintainers' section from PR template (#1856)"). This simplifies the template to its essentials, while keeping the descriptive checklist code comment. Link: #1869 Approved-by: Daniel Thwaites <danth@danth.me> (cherry picked from commit 989312a)
Remove the explicit 'Submission Checklist' header since it is the only header in the template section after applying commits e544f6e ("ci: visually distinguish user description from PR template content (#1802)") and 2355da4 ("ci: remove 'Notify Maintainers' section from PR template (#1856)"). This simplifies the template to its essentials, while keeping the descriptive checklist code comment. Link: #1869 Approved-by: Daniel Thwaites <danth@danth.me> (cherry picked from commit 989312a)
…ty#1856) Link: nix-community#1856 Reviewed-by: Daniel Thwaites <danth@danth.me> Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
now that we have automatic review requesting it's unnecessary
Submission Checklist
Notify Maintainers