doc: commit_convention: overhaul and formalize unspoken rules#1717
Merged
0xda157 merged 1 commit intonix-community:masterfrom Jul 28, 2025
Conversation
5 tasks
0xda157
reviewed
Jul 17, 2025
trueNAHO
commented
Jul 17, 2025
trueNAHO
commented
Jul 18, 2025
6 tasks
dfe3d9a to
9a3953f
Compare
0xda157
reviewed
Jul 24, 2025
9a3953f to
094767e
Compare
Contributor
|
Successfully created backport PR for |
0xda157
pushed a commit
that referenced
this pull request
Jul 28, 2025
6 tasks
trueNAHO
added a commit
to trueNAHO/stylix
that referenced
this pull request
Aug 26, 2025
Fixes: 57d036d ("doc: commit_convention: overhaul and formalize unspoken rules (nix-community#1717)")
0xda157
reviewed
Sep 4, 2025
Comment on lines
+86
to
+88
| Automated backport PRs should be rebase-merged to retain the original commit | ||
| author and leverage the automatically appended `(cherry picked from commit | ||
| «COMMIT_HASH»)` line. |
Contributor
There was a problem hiding this comment.
not sure if this always the best option, currently prs that are merged using a merge commit lose that merge commit on the stable branch which feels somewhat undesirable.
Member
Author
There was a problem hiding this comment.
not sure if this always the best option, currently prs that are merged using a merge commit lose that merge commit on the stable branch which feels somewhat undesirable.
Yes, this has also been bothering me. However, the current Backport action does not retain this information in the generated PR. Feel free to open an issue or submit a PR.
make-42
pushed a commit
to make-42/stylix
that referenced
this pull request
Sep 13, 2025
…mmunity#1717) Link: nix-community#1717 Reviewed-by: awwpotato <awwpotato@voidq.com>
MrSom3body
pushed a commit
to MrSom3body-contrib/stylix
that referenced
this pull request
Sep 18, 2025
Fixes: 57d036d ("doc: commit_convention: overhaul and formalize unspoken rules (nix-community#1717)")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a superset of #1622.
This PR is best viewed in rendered form:
nix run github:trueNAHO/stylix/doc-commit-convention-overhaul-and-formalize-unspoken-rules#docCC: @awwpotato @danth
Things done
Notify maintainers